Conversation
…device time Co-authored-by: atarukun <6511495+atarukun@users.noreply.github.com>
… clearer constant Co-authored-by: atarukun <6511495+atarukun@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix incorrect date calculation for days until Christmas
Fix Christmas countdown using internet time instead of unreliable device clock
Oct 30, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds network-based time fetching functionality to the Christmas countdown badge application to ensure accurate date calculations. The implementation fetches the current date from worldtimeapi.org and falls back to local system time if the network is unavailable.
- Implements network-based date fetching from worldtimeapi.org API with caching and error handling
- Updates
get_days_until_christmas()to prioritize internet time over local time - Adds graceful fallback to local time when network is unavailable or fetch fails
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: atarukun <6511495+atarukun@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan to fix incorrect date calculation in Christmas countdown app:
Summary
Fixed the Christmas countdown app showing incorrect days (358 instead of ~56) by fetching the current date from the internet instead of relying on the device's potentially inaccurate local clock.
Key Changes:
fetch_current_date()function that fetches current date from worldtimeapi.org APISecurity:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.